You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The IDE auto-formatters of many contributors will do things like add semicolons, change quotes from single to double, ... making PR diffs hard to read and causing merge conflicts between branches.
This is a feature request for us to use a strict linter and a Github Actions workflow to check code style. Merging of PRs should only be allowed if and only if the code style check passes.
Currently, ChRIS_ui uses a permissive canned eslint configuration.
ChRIS_ui/package.json
Line 67 in 49193ea
The IDE auto-formatters of many contributors will do things like add semicolons, change quotes from single to double, ... making PR diffs hard to read and causing merge conflicts between branches.
This is a feature request for us to use a strict linter and a Github Actions workflow to check code style. Merging of PRs should only be allowed if and only if the code style check passes.
We can steal the eslint configuration from ChRIS_store_ui. See FNNDSC/ChRIS_store_ui#168 and its linked PR FNNDSC/ChRIS_store_ui#229
The text was updated successfully, but these errors were encountered: