Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce strict code style to prevent merge conflicts #698

Closed
jennydaman opened this issue Oct 14, 2022 · 3 comments
Closed

Enforce strict code style to prevent merge conflicts #698

jennydaman opened this issue Oct 14, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@jennydaman
Copy link
Collaborator

jennydaman commented Oct 14, 2022

Currently, ChRIS_ui uses a permissive canned eslint configuration.

"lint": "eslint '*/**/*.{js,ts,tsx}' --quiet --fix",

The IDE auto-formatters of many contributors will do things like add semicolons, change quotes from single to double, ... making PR diffs hard to read and causing merge conflicts between branches.

This is a feature request for us to use a strict linter and a Github Actions workflow to check code style. Merging of PRs should only be allowed if and only if the code style check passes.

We can steal the eslint configuration from ChRIS_store_ui. See FNNDSC/ChRIS_store_ui#168 and its linked PR FNNDSC/ChRIS_store_ui#229

@jennydaman jennydaman added the good first issue Good for newcomers label Oct 14, 2022
@Timonwa
Copy link
Contributor

Timonwa commented Oct 14, 2022

I will work on this.

@nanfuka
Copy link

nanfuka commented Oct 17, 2022

@Timonwa can I collaborate with you on this on this issues. i have some experience there.

@Timonwa
Copy link
Contributor

Timonwa commented Oct 17, 2022

No problem @nanfuka. I made a comment on the pull request. Let me tag you on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
4 participants