Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspending a VM only turns it off #19

Open
BelleNottelling opened this issue Jun 8, 2023 · 1 comment
Open

Suspending a VM only turns it off #19

BelleNottelling opened this issue Jun 8, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@BelleNottelling
Copy link
Member

When an order is suspended, the only action that is performed is to turn off a VM.
This does nothing to prevent a client from simply turning their VM back on in the event they don't pay. It doesn't even update the status for the order in the DB.

Relevant code: https://github.com/FOSSBilling/Proxmox/blob/main/Service.php#L360
Cancelling an order also has the same behavior as it simply references the canceling suspending function.

@BelleNottelling
Copy link
Member Author

I was slightly wrong about this.
FOSSBilling will correctly set the status of the order itself when the action is called, however the module doesn't check the status before allowing actions to be performed on the server:

https://github.com/FOSSBilling/Proxmox/blob/main/Api/Client.php#L97
https://github.com/FOSSBilling/Proxmox/blob/main/Service.php#L635

@Anuril Anuril added the bug Something isn't working label Sep 20, 2023
@Anuril Anuril moved this to 0.1.0 in Proxmox Module Roadmap Sep 20, 2023
@Anuril Anuril self-assigned this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 0.1.0
Development

No branches or pull requests

2 participants