Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra should read IPv4 "class E" from kernel regardless of allow-reserved-ranges #17942

Open
eqvinox opened this issue Jan 28, 2025 · 6 comments

Comments

@eqvinox
Copy link
Contributor

eqvinox commented Jan 28, 2025

It's not currently possible to set allow-reserved-ranges early enough to make the initial RIB read in zebra work correctly; config is only loaded after that has already completed.

But more generally speaking, there's an argument to be made here that zebra should always accept Class E from the kernel regardless of the setting; the kernel is the source of truth here and it's not particularly helpful to intentionally desync our RIB view. The switch should probably only control:

  • what we permit to load as config (i.e. static routes and addresses in config)
  • what we accept from routing protocol neighbors
  • whether we feed Class E out into routing protocols

⇒ probably needs a bit of discussion

@donaldsharp
Copy link
Member

I'm ok with accepting the kernels source of truth. It might make it fun in some of the protocols when we have a redistribute kernel command though.

@ton31337
Copy link
Member

the kernel is the source of truth here and it's not particularly helpful to intentionally desync our RIB view.

Agree.

@donaldsharp
Copy link
Member

Let's discuss this dduring today's call.

@eqvinox
Copy link
Contributor Author

eqvinox commented Jan 28, 2025

Let's discuss this dduring today's call.

Exactly why I filed this 😄

FWIW the switch should also control whether we redistribute routes into routing protocols. If it's not set, we can still pretend the routes don't exist when feeding out redistributes…

@eqvinox
Copy link
Contributor Author

eqvinox commented Jan 28, 2025

related: #16326

@davischw
Copy link
Contributor

davischw commented Jan 30, 2025

Should zebra remove class E addresses from a loopback interface configured by frr on daemon shutdown if the interface is still up (loopback should never flap)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants