Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing only odometry messages contain wrong data #283

Closed
mateusz-lichota opened this issue Feb 2, 2022 · 1 comment
Closed

Testing only odometry messages contain wrong data #283

mateusz-lichota opened this issue Feb 2, 2022 · 1 comment

Comments

@mateusz-lichota
Copy link
Contributor

The definition of the Odometry message message says "The twist in this message should be specified in the coordinate frame given by the child_frame_id". However, the testing only Odometry message that the fsds_ros2_bridge (and probably also fsds_ros_bridge) publishes contains both pose and twist in the map frame, which causes errors when processing that data with applications assuming adherence to the standard (like robot_localization). I'm changing this behavior in my fork; let me know if you'd like a pull request with the changes to this repo.

@wouter-heerwegh
Copy link
Member

It would be nice to have these changes indeed. I think the behaviour of the GSS is wrong aswell, as it is also showing the speed of the car in the map frame. We'll port the changes also to ros 1 and the GSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants