New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use string comparision in dynamic_component #317

Open

k-knosala opened this issue Feb 28, 2024 · 0 comments

Assignees

Labels

Contributor

k-knosala commented Feb 28, 2024

Hey,

the dynamic componennt compares inputs and outputs by comparing their names as far as I understand.

Imo this approach leads to problems when adding more channels.

Is there another way to solve this?

https://github.com/FZJ-IEK3-VSA/HiSim/blob/1ab0f639a938075ce4e3617c4d834433e1cfa885/hisim/dynamic_component.py#L184C1-L197C12

k-knosala assigned noah80

k-rieck added the improvement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment