Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] add token to codecov CI #261

Closed
xgui3783 opened this issue Feb 7, 2023 · 4 comments
Closed

[chore] add token to codecov CI #261

xgui3783 opened this issue Feb 7, 2023 · 4 comments
Assignees
@AhmetNSimsek
Labels
maintenance Not a bug or breaking issue. Code maintenance related.

Comments

@xgui3783
Copy link
Member

xgui3783 commented Feb 7, 2023

In order to prevent

false positive in tests: https://github.com/FZJ-INM1-BDA/siibra-python/actions/runs/4111966133/jobs/7096311370
@AhmetNSimsek
Copy link
Collaborator

AhmetNSimsek commented Apr 3, 2023 •
edited
Loading

Isn't this already done as of 3bef0dd?

@xgui3783
Copy link
Member Author

xgui3783 commented Apr 3, 2023

actually, seems to be very heisenburg

see issue: codecov/codecov-action#598

I think I read somewhere that it could be rate limiting issue.

adding access token should solve the issue.

@xgui3783 xgui3783 changed the title [chore] codecov CI to only trigger on PR on main [chore] add token to codecov CI Apr 3, 2023
@AhmetNSimsek AhmetNSimsek self-assigned this Apr 3, 2023
@AhmetNSimsek AhmetNSimsek added the maintenance Not a bug or breaking issue. Code maintenance related. label Apr 18, 2023
@AhmetNSimsek
Copy link
Collaborator

AhmetNSimsek commented Jan 24, 2024 •
edited
Loading

It seems adding a token won't solve the issue as it is a solution for private repos. (see the issue mentioned above)

@AhmetNSimsek AhmetNSimsek mentioned this issue Jan 26, 2024
Merged
@AhmetNSimsek
Copy link
Collaborator

solved with #616 and adding new codecov secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AhmetNSimsek AhmetNSimsek

Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xgui3783 @AhmetNSimsek