Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] feature matching of ebrains dataset should be reworked #352

Open
xgui3783 opened this issue Apr 20, 2023 · 0 comments
Open

Comments

@xgui3783
Copy link
Member

xgui3783 commented Apr 20, 2023

Currently, feature matching of ebrains dataset is done via fuzzy match of region names and species (anchor in siibra compared to study target in KG). However, since each region has a uuid, the matching should be done with uuid matching. This has several advantages:

  • non ambiguous parsing of region in anatomicalanchor. Currently, name and species is provided to anatommical anchor. The anatomical anchor needs to parse the region name (as a string), which is computationally intensive.
  • we get, for free, semantic links, already established in the KG (homologies across species, prior versions, etc)
  • currently region instances in siibra lacks id. This would introduce persistence reference to region instances, and brings it inline with the uuid of parcellation entity version (KG equivalent of region instances)

Potential blocking issues

  • region instance in siibra does not map 1-1 to parcellation entity version in KG. hoc1 left for example, maps to 3 instances, one in each spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants