Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Links on the Site [Enhancement] #178

Open
Bogie21 opened this issue Sep 22, 2015 · 2 comments
Open

Modify Links on the Site [Enhancement] #178

Bogie21 opened this issue Sep 22, 2015 · 2 comments

Comments

@Bogie21
Copy link

Bogie21 commented Sep 22, 2015

Links such as profile should load to a pop-up box similar to the "Cog" (Setting) window. This will help user continuitity on the site. It wont pull users away from the music room they are in. Especially when trying to view other users profiles.

Along with this, any link that takes you away from the site should be loaded in a new tab by default, bypassing the user set preferences (Settings -> Behavior -> Always Open Links in New Window). (IE Chrome Extension, Donate Bitcoin, etc. should always load a new tab)

@martindale
Copy link
Member

Bypassing user preferences is something we want to avoid, so we instead have a setting to "Always open links in a new window" up top, in the settings window. When we implement a proper single-page application, the music will keep playing if you click an on-site link, but will open new links in new windows.

@Bogie21
Copy link
Author

Bogie21 commented Sep 22, 2015

I understand avoiding bypassing user preferences. This, realistically, wouldn't modify that user setting, though. By default, all links load a new page on the same tab. The exception to this should be links which take you away from your site. This way, whether the box is checked or not, all external links will open a new tab. This way you're not driving visitors away from your site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants