Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry mapping #237

Closed
liach opened this issue Apr 29, 2020 · 4 comments
Closed

Fix entry mapping #237

liach opened this issue Apr 29, 2020 · 4 comments
Labels

Comments

@liach
Copy link
Contributor

liach commented Apr 29, 2020

For long, Entry mapping can be null, indicating an absence of mapping. Entry mapping always require a mapped name to be present; however, besides mapped names, it carries other information, mainly access modifier change and javadoc.

As a result, you cannot have standalone javadoc information without mapping. This has become problematic, and a solution is to revamp all entry tree usages from nullable entry mapping to non-null no-op entry mapping instead, and we can revamp entry mapping itself to carry javadoc information without a rename.

@Runemoro Runemoro added the bug label Apr 29, 2020
@Runemoro
Copy link
Contributor

I think #188 fixes this?

@modmuss50
Copy link
Member

Looks like it does.

It will need testing.

@liach
Copy link
Contributor Author

liach commented Apr 29, 2020

That pr misses a lot of places, as in existing enigma code there is widespread assumption that target name cannot be null in an entry mapping, and that pr apparently takes care of none of that. Also that pr allows an entry mapping to be effectively same as null by having null javadoc + null target name, yet that pr does not handle that at all (still using null checks without checking members)

@YanisBft
Copy link
Contributor

YanisBft commented Jul 8, 2021

Fixed by #364 it seems

@YanisBft YanisBft closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants