Help with making custom enchantment

[Dog517]

Hi, so im making a mod that adds an enchantment that when you hit an enemy, it summons a cow. It is working, but it is summoning 2 cows instead of 1. any help?

ModCowEnchantment class:

package net.dogdev.stuffmod.enchantment;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentTarget;
import net.minecraft.entity.*;
import net.minecraft.server.world.ServerWorld;
import net.minecraft.text.Text;
import net.minecraft.util.math.BlockPos;

public class ModCowEnchantment extends Enchantment {
    public ModCowEnchantment(Rarity weight, EnchantmentTarget type, EquipmentSlot... slotTypes) {
        super(weight, type, slotTypes);
    }


    @Override
    public void onTargetDamaged(LivingEntity user, Entity target, int level) {
        if(!user.world.isClient()) {
            ServerWorld world = (ServerWorld)user.world;
            BlockPos position = target.getBlockPos();
            String name = "John";
            String name2 = "Jeff";

            if(level == 1) {
                EntityType.COW.spawn(world, null, Text.of(name), null, position,
                        SpawnReason.TRIGGERED, true, true);
            }

            if(level == 2) {
                EntityType.COW.spawn(world, null, Text.of(name), null, position,
                        SpawnReason.TRIGGERED, true, true);
                EntityType.COW.spawn(world, null, Text.of(name2), null, position,
                        SpawnReason.TRIGGERED, true, true);
            }
        }

        super.onTargetDamaged(user, target, level);
    }

    @Override
    public int getMaxLevel() {
        return 2;
    }}

ModEnchantment class:

package net.dogdev.stuffmod.enchantment;
import net.dogdev.stuffmod.StuffMod;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.enchantment.EnchantmentTarget;
import net.minecraft.entity.EquipmentSlot;
import net.minecraft.util.Identifier;
import net.minecraft.util.registry.Registry;

public class ModEnchantments {
    public static Enchantment COW_SUMMON = register("cow_summon",
            new ModCowEnchantment(Enchantment.Rarity.UNCOMMON,
                    EnchantmentTarget.WEAPON, EquipmentSlot.MAINHAND));


    private static Enchantment register(String name, Enchantment enchantment) {
        return Registry.register(Registry.ENCHANTMENT, new Identifier(StuffMod.MOD_ID, name), enchantment);
    }

    public static void registerModEnchantments() {
        System.out.println("Registering Enchantments for " + StuffMod.MOD_ID);
    }
}

[SirEnder125]

To be sure, your code does have functionality to spawn two cows. If the enchantment level is 2, two cows will spawn, if the level is 1, one cow will spawn. Make sure you are enchanting your item with your desired level. Also if(level == 2) can be else if (level == 2)

[Dog517]

yeah, I made it so at level 2, 2 cows will spawn. But my problem is at level 1 it will summon 2 cows named "John", and at level 2 it will summon 2 cows named "John" and 2 cows named "Jeff".

[SirEnder125]

I tried out your code in one of my mods, and debugged while using a sword enchanted with the enchantment. onTargetDamaged() is called twice on the server, it seems. I'm not sure why yet.