Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remap class if two parents contain methods with same mapped name but different intermediary names #47

Open
CoolMineman opened this issue Feb 18, 2021 · 1 comment

Comments

@CoolMineman
Copy link

If a class extending Item implements ToolMaterial and overrides getEnchantability it creates the following error when compiling in loom. This is because Item's getEnchantability is method_7837 in yarn and ToolMaterial's getEnchantability method_8026. Maybe tiny-remapper should dupe the method and warn?

:remapping fluxtech-2.0.0-dev.jar
Mapping source name conflicts detected:
  net/minecraft/item/ArmorItem METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/ArmorItem/method_8026]
  net/minecraft/item/TridentItem METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/TridentItem/method_8026]
  net/minecraft/item/ToolMaterial METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/ToolMaterial/method_8026]
  net/minecraft/item/ToolItem METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/ToolItem/method_8026]
  net/minecraft/item/RangedWeaponItem METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/RangedWeaponItem/method_8026]
  net/minecraft/item/ToolMaterials METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/ToolMaterials/method_8026]
  com/fusionflux/fluxtech/items/SwordTestItem METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, com/fusionflux/fluxtech/items/SwordTestItem/method_8026]
  net/minecraft/item/BookItem METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/BookItem/method_8026]
  net/minecraft/item/Item METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/Item/method_8026]
  net/minecraft/item/FishingRodItem METHOD getEnchantability (()I) -> [net/minecraft/item/Item/method_7837, net/minecraft/item/FishingRodItem/method_8026]
@liach
Copy link
Contributor

liach commented Jul 28, 2021

Related: FabricMC/yarn#2601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants