Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 17w46a #2302

Closed
Bixilon opened this issue Apr 9, 2021 · 5 comments
Closed

Backport to 17w46a #2302

Bixilon opened this issue Apr 9, 2021 · 5 comments

Comments

@Bixilon
Copy link
Contributor

Bixilon commented Apr 9, 2021

I am writing my own minecraft client, that supports multiprotocol. My client supports all versions up from 13w42b. Because of the "flattening update" (17w47a), I load for every newer version a json file, that my other project ("PixLyzer") generates.

Current yarn mappings are available from 18w43b. This is a version between 1.13.2 and 1.14. I still want to support these ~50 versions. I'd like to mainly focus on the major versions (1.13.2, 1.13.1, 1.13) and the last non flattened version 17w46a. The old "codebase" is pretty old and I am asking you how I should approach this.

I already saw https://fabricmc.net/wiki/tutorial:updating_yarn and #1826 but it looks like, it only applies to old versions. Because yarn is using branch hell, I need to know from what branch I should start.

Thanks for any advice, help or suggestions

Moritz

@OroArmor
Copy link
Contributor

OroArmor commented Apr 9, 2021

You can make intermediary for that version, but making yarn for it makes no sense unless you plan to mod it yourself. I would start from the 18w43b branch as that will have the least changes from 1.13. however i don't know why you plan on supporting 1.13 when almost everyone who uses 1.13 has upgraded to more recent versions

@Bixilon
Copy link
Contributor Author

Bixilon commented Apr 9, 2021

Yah, idk either. Kind of a proof of concept, that was the goal for my project, In retrospect it was pretty dumb idea, but I still want to fullfill my goals. But 1.13 is less important, than 17w46a is more important, because it is the required version for 1.8 and 1.12 (and these are still in use)

@modmuss50
Copy link
Member

This is not something we have the time to handle. There is more than enough stuff that keeps me busy on the latest versions. You are free to look into doing it yourself however, all of the tools are freely available.

https://fabricmc.net/wiki/tutorial:updating_yarn

This wiki page is a good place to start.

@Bixilon
Copy link
Contributor Author

Bixilon commented Apr 9, 2021

Also don't have much time for it now, but it is a general question (for me at least). I'll try it, using the wiki page, let's see.

(Will make a PR once ready, if you are interested).

Thanks for the suggestions

@modmuss50
Copy link
Member

I dont plan on accepting PRs for older version at the moment. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants