Map ByteArray codecs in PacketCodecs #3960
Conversation
Im not sure if unpick can unpick only within a certain class, as we wouldnt want to unpick this for all |
|
I feel like this has to be a bug in the toolchain, not a mapping issue. |
|
Yeah, this feels like an issue with specialised methods, which has happened before (see also #3916 which makes largely the same changes and wasn't merged). |
|
I didn't notice that PR, sorry |
|
Is it broken in dev? Does this work around it? If so maybe it is fine to merge idk. |
|
See #3917 for how this issue manifests during development |
|
This fix / workaround seems fine then. Unless you want to go digging for the root cause of the issue I dont have a problem with this for now? |
|
I'm not familiar enough with the toolchain to fix this myself. I submitted this PR because I saw that there were already mappings for |
Fixes #3917
This issue was very weird to me. Other codecs had
encodeanddecodeas their method names, but were marked obfuscated and there were no mappings for these methods except for the PacketCodec returned by thebyteArraymethod. I'm not sure whyBYTE_ARRAYfield andbyteArraymethod require manual mapping.Also I mapped a constant that defines the maximum size a collection can be initialized with when reading collections. I think it needs to be unpicked to work properly, but I don't know how.