Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SPR Marked As Broken #1512

Closed
Fyoncle opened this issue Jun 3, 2024 · 5 comments
Closed

Revert SPR Marked As Broken #1512

Fyoncle opened this issue Jun 3, 2024 · 5 comments
Labels
type: bug Issue where something isn't working

Comments

@Fyoncle
Copy link

Fyoncle commented Jun 3, 2024

Describe the Bug

The bug has been solved by henkelmax already.
henkelmax/sound-physics-remastered#172

Reproduction Steps

To solve this;

  1. Revert back the changes you made on SPR to avoid using it together.

Expected Result

If you add a config on fabric dependencies config most likely like;
{
"version": 1,
"overrides": {
"create": {
"breaks": {
"sound_physics_remastered": "<1.4.0"
}
}
}
}

Then Create can work perfectly fine with SPR Mod with latest releases.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Other Mods

No response

Additional Context

No response

@Fyoncle Fyoncle added the type: bug Issue where something isn't working label Jun 3, 2024
@IThundxr
Copy link
Member

IThundxr commented Jun 3, 2024

please actually look at what i said, it's fixed in dev already

@IThundxr IThundxr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
@Fyoncle
Copy link
Author

Fyoncle commented Jun 3, 2024

please actually look at what i said, it's fixed in dev already

Wdym In Dev?? where he said that.

@IThundxr
Copy link
Member

IThundxr commented Jun 3, 2024

henkelmax/sound-physics-remastered#172 (comment)
henkelmax/sound-physics-remastered#172 (comment)

The next version of Create Fabric is expected to remove that declaration of incompatibility. b12d4d8

@Fyoncle
Copy link
Author

Fyoncle commented Jun 3, 2024

henkelmax/sound-physics-remastered#172 (comment) henkelmax/sound-physics-remastered#172 (comment)

The next version of Create Fabric is expected to remove that declaration of incompatibility. b12d4d8

I thought you mean SPR

@skellitor301
Copy link

Is there any planned eta for when this will be released to Modrinth/Curseforge? Or are there still other things still being worked on for the next version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants