Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Starlight #1629

Closed
MikiP98 opened this issue Oct 18, 2024 · 5 comments
Closed

Incompatibility with Starlight #1629

MikiP98 opened this issue Oct 18, 2024 · 5 comments
Labels
type: crash Issue where the game crashes

Comments

@MikiP98
Copy link

MikiP98 commented Oct 18, 2024

Context

I've enebled mechanical bearing, or I've joined a world with a enabled mechanical bearing or I've generated or world with Create Structures.

Tested versions:

  • MC 1.20.1
  • Starlight 1.1.2+1.20
  • Create 0.5.1-f-build.1417+mc1.20.1

Error:

java.lang.ClassCastException: class com.simibubi.create.content.contraptions.render.ContraptionRenderDispatcher$1 cannot be cast to class net.minecraft.class_638 (com.simibubi.create.content.contraptions.render.ContraptionRenderDispatcher$1 and net.minecraft.class_638 are in unnamed module of loader 'knot' @2a2d45ba)

Crash Report:
crash-2024-10-18_22.47.27-client.txt
I know there is a lot of mods here, I don't mahe time right now to test only Starlight with Create, the possibility of this crash can at least be mentioned on the project page.

Crash Report

https://mclo.gs/WPVmaFD

@MikiP98 MikiP98 added the type: crash Issue where the game crashes label Oct 18, 2024
@IThundxr
Copy link
Member

Starlight is both abandoned and no longer needed on 1.20.1, this is already mentioned on the starlight modrinth and curseforge pages

https://gist.github.com/Spottedleaf/6cc1acdd03a9b7ac34699bf5e8f1b85c

@IThundxr IThundxr closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@MikiP98
Copy link
Author

MikiP98 commented Oct 19, 2024

Well, there are people that disagree: https://github.com/RelativityMC/ScalableLux
I just want Starlight to be added as Incompatible on Modrinth version pages or as breaks inside fabric.mod.json

@IThundxr
Copy link
Member

Well, there are people that disagree: https://github.com/RelativityMC/ScalableLux I just want Starlight to be added as Incompatible on Modrinth version pages or as breaks inside fabric.mod.json

Report this to them so they can fix it or remove the mod.

@MikiP98
Copy link
Author

MikiP98 commented Oct 20, 2024

I already removed Starlight, Create is a bigger priority, but...
...you've marked a Compatible mod Sound Physics Remastered as incompatible, but you don't want to mark an actual incompatible mod as such?
Well you do you I guess...
Have a nice day!

@IThundxr
Copy link
Member

IThundxr commented Oct 20, 2024

I already removed Starlight, Create is a bigger priority, but... ...you've marked a Compatible mod Sound Physics Remastered as incompatible, but you don't want to mark an actual incompatible mod as such? Well you do you I guess... Have a nice day!

henkelmax/sound-physics-remastered#172 The reason SPR was marked as broken was after notifying the author of a pretty big issue that had caused many invalid bug reports to be submitted to create and create fabric.

As you can see it was later removed and then replaced with a breaks for older broken versions.

If people are willingly using a mod that even the author has said isn't really needed then that is on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: crash Issue where the game crashes
Projects
None yet
Development

No branches or pull requests

2 participants