Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Utf8NoBom instance in more places #806

Open
Kermalis opened this issue Feb 4, 2025 · 0 comments
Open

Use Utf8NoBom instance in more places #806

Kermalis opened this issue Feb 4, 2025 · 0 comments

Comments

@Kermalis
Copy link

Kermalis commented Feb 4, 2025

With the latest commit 0595c9c, Utf8StringToNative.Utf8NoBom was introduced for safety. However, there are other places in the library where Encoding.UTF8 is still used. For example, GameRichPresenceJoinRequested_t

internal string ConnectUTF8() => System.Text.Encoding.UTF8.GetString( Connect, 0, System.Array.IndexOf<byte>( Connect, 0 ) );

The generator should be updated to use the new NoBom instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant