-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalization enhancement/pallet #197
Comments
Concerning the Note, the seller by submitting the proposal in the previous steps has already approved the sale. He/She had time to make his/her decision. What is the need to have an another approval after the voting process? I propose it's assumed that the seller approval is already done, for the MVP at least. |
ImplemenationIn order to implement the asset processs finalization.
|
The seller should have the opportunity to back-out of the deal. For now this won't have any consquences, but there should be some penalty fees, for invoking everyone's time and energy to bring it to a sale and then back-out |
In M3 we implemented in the
bidding pallet
the eventInvestorListCreationSuccessful
when an asset is onboarded and a successfulinvestors list
is able to be created. If nothing is done with the current state in the next epoch it switches toprocess_finalised_assets
.The enhancement
Instead of the runtime changing the state, we need someone with authoritity to finalize the deal for the title transfers. The authority is set by the law and it checks the shareholders and the asset to approve.
The new flow:
Note The seller should also approve the sale in this intermediate step, we assume that they are willing to sale for the price. In a production env this will be the case.
Further Requirements:
NftItemId
that is in question0x....
Finalizing
is applied when the reserved list of investors and the asset is being finalized.finalizing
we don't want thebidding-pallet
to reserve a new investors list. The asset should essentially be locked.structure
Let's create a new pallet for this functionality, as this will be expanded a lot in the future.
The text was updated successfully, but these errors were encountered: