Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto conversion of detections #421

Open
geowalrus4gh opened this issue Dec 6, 2022 · 2 comments
Open

Auto conversion of detections #421

geowalrus4gh opened this issue Dec 6, 2022 · 2 comments
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: could Future work depending on bandwidth and availability

Comments

@geowalrus4gh
Copy link

feature

Is it possible to replace the scan findings with the target version's declarations?

Describe the solution you'd like

Something like "pluto detect-files --target-versions k8s=v1.24.0 --replace"

This will replace the version definition with the target definition and ensure the yaml is compatible with target spec. Throw error if not backward compatible.

@geowalrus4gh geowalrus4gh added enhancement Adding additional functionality or improvements triage This bug needs triage labels Dec 6, 2022
@sudermanjr
Copy link
Member

This is an interesting idea. We've talked about it in the past I believe, but never made any serious effort. This would be a fairly large change, as we would have to modify the versions spec to include an indicator of backward compatibility

@sudermanjr sudermanjr changed the title Auto convertion of detections Auto conversion of detections Dec 6, 2022
@sudermanjr sudermanjr added priority: could Future work depending on bandwidth and availability pinned Prevents stalebot from removing and removed triage This bug needs triage labels Dec 6, 2022
@arushdesp
Copy link

arushdesp commented Apr 18, 2024

Isnt it already working kinda working?
Tried to replicate it:
pluto detect-files -f api-dreprecated.yaml
image
You see the replacement column, in my case i had the yaml files with deprecations in the directory i launched the command.
To fix the "issues" you can just change the apiVersion to the one indicated to the column of the replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: could Future work depending on bandwidth and availability
Projects
None yet
Development

No branches or pull requests

3 participants