Enhancement: Declare strict types in test/ (#780)

* Enhancement: Require code in test/ to declare strict types

* Fix: Run 'make cs'

* Fix: Cast values to expected types

Author: localheinz

.gitattributes

@@ -5,6 +5,8 @@
 /.gitattributes           export-ignore
 /.gitignore               export-ignore
 /.php-cs-fixer.dist.php   export-ignore
+/.php-cs-fixer.rules.php  export-ignore
+/.php-cs-fixer.test.php   export-ignore
 /.yamllint.yaml           export-ignore
 /codecov.yml              export-ignore
 /Makefile                 export-ignore

.github/workflows/coding-standards.yaml

@@ -60,6 +60,10 @@ jobs:
         run: |
           vendor/bin/php-cs-fixer fix --ansi --diff --dry-run --verbose
 
+      - name: "Run php-cs-fixer for test code"
+        run: |
+          vendor/bin/php-cs-fixer fix --ansi --config=.php-cs-fixer.test.php --diff --dry-run --verbose
+
   yamllint:
     name: "yamllint"
 

.php-cs-fixer.dist.php

@@ -6,11 +6,9 @@
     ->exclude([
         '.build/',
         '.github/',
+        'test/',
         'vendor-bin/',
     ])
-    ->notPath([
-        'test/Fixture/Enum/BackedEnum.php',
-    ])
     ->ignoreDotFiles(false)
     ->in(__DIR__);
 
@@ -20,221 +18,10 @@
     mkdir('.build/php-cs-fixer', 0755, true);
 }
 
+$rules = require __DIR__ . '/.php-cs-fixer.rules.php';
+
 return $config
     ->setCacheFile('.build/php-cs-fixer/cache')
     ->setFinder($finder)
     ->setRiskyAllowed(true)
-    ->setRules([
-        '@PSR2' => true,
-        'array_indentation' => true,
-        'array_syntax' => [
-            'syntax' => 'short',
-        ],
-        'binary_operator_spaces' => true,
-        'blank_line_after_opening_tag' => true,
-        'blank_line_before_statement' => [
-            'statements' => [
-                'break',
-                'continue',
-                'default',
-                'do',
-                'exit',
-                'for',
-                'foreach',
-                'if',
-                'include',
-                'include_once',
-                'require',
-                'require_once',
-                'return',
-                'switch',
-                'throw',
-                'try',
-                'while',
-                'yield',
-            ],
-        ],
-        'blank_lines_before_namespace' => [
-            'max_line_breaks' => 2,
-            'min_line_breaks' => 2,
-        ],
-        'cast_spaces' => true,
-        'class_attributes_separation' => [
-            'elements' => [
-                'method' => 'one',
-            ],
-        ],
-        'combine_nested_dirname' => true,
-        'compact_nullable_typehint' => true,
-        'concat_space' => [
-            'spacing' => 'one',
-        ],
-        'control_structure_braces' => true,
-        'control_structure_continuation_position' => true,
-        'curly_braces_position' => true,
-        'declare_equal_normalize' => true,
-        'declare_parentheses' => true,
-        'general_phpdoc_annotation_remove' => [
-            'annotations' => [
-                'author',
-            ],
-        ],
-        'global_namespace_import' => [
-            'import_classes' => false,
-            'import_constants' => false,
-            'import_functions' => false,
-        ],
-        'implode_call' => true,
-        'increment_style' => true,
-        'is_null' => true,
-        'lambda_not_used_import' => true,
-        'list_syntax' => [
-            'syntax' => 'short',
-        ],
-        'lowercase_cast' => true,
-        'lowercase_static_reference' => true,
-        'magic_constant_casing' => true,
-        'magic_method_casing' => true,
-        'modernize_types_casting' => true,
-        'multiline_comment_opening_closing' => true,
-        'new_with_braces' => true,
-        'no_alias_functions' => true,
-        'no_blank_lines_after_class_opening' => true,
-        'no_blank_lines_after_phpdoc' => true,
-        'no_empty_phpdoc' => true,
-        'no_empty_statement' => true,
-        'no_extra_blank_lines' => true,
-        'no_leading_import_slash' => true,
-        'no_leading_namespace_whitespace' => true,
-        'no_multiple_statements_per_line' => true,
-        'no_spaces_around_offset' => true,
-        'no_superfluous_elseif' => true,
-        'no_superfluous_phpdoc_tags' => true,
-        'no_trailing_comma_in_singleline' => [
-            'elements' => [
-                'array',
-            ],
-        ],
-        'no_unneeded_control_parentheses' => true,
-        'no_unneeded_curly_braces' => true,
-        'no_unneeded_final_method' => true,
-        'no_unreachable_default_argument_value' => true,
-        'no_unset_cast' => true,
-        'no_unused_imports' => true,
-        'no_useless_else' => true,
-        'no_whitespace_before_comma_in_array' => true,
-        'no_whitespace_in_blank_line' => true,
-        'non_printable_character' => true,
-        'normalize_index_brace' => true,
-        'operator_linebreak' => [
-            'only_booleans' => true,
-            'position' => 'beginning',
-        ],
-        'ordered_imports' => true,
-        'php_unit_construct' => true,
-        'php_unit_dedicate_assert' => true,
-        'php_unit_dedicate_assert_internal_type' => true,
-        'php_unit_expectation' => true,
-        'php_unit_fqcn_annotation' => true,
-        'php_unit_method_casing' => true,
-        'php_unit_mock' => true,
-        'php_unit_mock_short_will_return' => true,
-        'php_unit_namespaced' => true,
-        'php_unit_no_expectation_annotation' => true,
-        'php_unit_set_up_tear_down_visibility' => true,
-        'php_unit_test_case_static_method_calls' => [
-            'call_type' => 'self',
-        ],
-        'phpdoc_align' => true,
-        'phpdoc_indent' => true,
-        'phpdoc_inline_tag_normalizer' => true,
-        'phpdoc_line_span' => true,
-        'phpdoc_no_access' => true,
-        'phpdoc_no_alias_tag' => [
-            'replacements' => [
-                'link' => 'see',
-                'type' => 'var',
-            ],
-        ],
-        'phpdoc_no_empty_return' => true,
-        'phpdoc_no_package' => true,
-        'phpdoc_order' => true,
-        'phpdoc_order_by_value' => [
-            'annotations' => [
-                'covers',
-                'dataProvider',
-                'group',
-                'requires',
-                'throws',
-                'uses',
-            ],
-        ],
-        'phpdoc_return_self_reference' => true,
-        'phpdoc_scalar' => true,
-        'phpdoc_separation' => true,
-        'phpdoc_single_line_var_spacing' => true,
-        'phpdoc_trim' => true,
-        'phpdoc_trim_consecutive_blank_line_separation' => true,
-        'phpdoc_types' => true,
-        'phpdoc_types_order' => [
-            'null_adjustment' => 'always_last',
-            'sort_algorithm' => 'alpha',
-        ],
-        'phpdoc_var_without_name' => true,
-        'pow_to_exponentiation' => true,
-        'protected_to_private' => true,
-        'psr_autoloading' => true,
-        'random_api_migration' => true,
-        'return_assignment' => true,
-        'return_type_declaration' => true,
-        'self_static_accessor' => true,
-        'semicolon_after_instruction' => true,
-        'short_scalar_cast' => true,
-        'single_line_comment_style' => true,
-        'single_quote' => true,
-        'single_space_around_construct' => [
-            'constructs_contain_a_single_space' => [],
-            'constructs_followed_by_a_single_space' => [
-                'elseif',
-                'for',
-                'foreach',
-                'if',
-                'match',
-                'while',
-                'use_lambda',
-            ],
-            'constructs_preceded_by_a_single_space' => [
-                'use_lambda',
-            ],
-        ],
-        'single_trait_insert_per_statement' => true,
-        'standardize_not_equals' => true,
-        'statement_indentation' => true,
-        'static_lambda' => true,
-        'strict_param' => true,
-        'switch_case_space' => true,
-        'ternary_operator_spaces' => true,
-        'ternary_to_null_coalescing' => true,
-        'trailing_comma_in_multiline' => [
-            'elements' => [
-                'arguments',
-                'arrays',
-            ],
-        ],
-        'trim_array_spaces' => true,
-        'type_declaration_spaces' => [
-            'elements' => [
-                'function',
-            ],
-        ],
-        'unary_operator_spaces' => true,
-        'visibility_required' => [
-            'elements' => [
-                'const',
-                'method',
-                'property',
-            ],
-        ],
-        'void_return' => false,
-        'whitespace_after_comma_in_array' => true,
-    ]);
+    ->setRules($rules);