Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinions on Providing a Fake for CIDR/IP Prefixes #796

Open
MichaelCrowcroft opened this issue Oct 7, 2023 · 3 comments
Open

Opinions on Providing a Fake for CIDR/IP Prefixes #796

MichaelCrowcroft opened this issue Oct 7, 2023 · 3 comments
Milestone

Comments

@MichaelCrowcroft
Copy link

Before submitting a PR keen to get thoughts on whether a method to provide CIDR blocks/IP Prefixes would make sense for this package.

Thinking something basic like the Ruby package has.

Appreciate this fairly simple to implement in projects with the existing methods, but feels like it would be nice to have.

@pimjansen
Copy link

pimjansen commented Oct 7, 2023

I agree that it could be a good thing though we are not adding new features to the 1.x.

@localheinz @bram-pkg i think we can include cidr blocks in the core packages right?

@bram-pkg
Copy link
Member

bram-pkg commented Oct 8, 2023

This sounds like an ideal core package candidate, yep.

@bram-pkg bram-pkg added this to the 2.0.0 milestone Oct 8, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants