Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/hidearmor is cleared by FabricTailor until rejoin #555

Open
sisby-folk opened this issue Oct 12, 2022 · 0 comments
Open

/hidearmor is cleared by FabricTailor until rejoin #555

sisby-folk opened this issue Oct 12, 2022 · 0 comments

Comments

@sisby-folk
Copy link

Game Log

Demo:
https://user-images.githubusercontent.com/55819817/195248797-d90ea31c-0ddc-4a6f-81e0-e83cbe82d44f.mp4

Reproduction steps:

  1. Enable hide armor
  2. equip a chestplate
  3. /hidearmor chest
  4. swap skins using fabric tailor
  5. chestplate is no longer hidden

This is some kind of client side desync (it's fixed by rejoining), and is likely related to the S2C respawn packet tailor uses to refresh skins for a player.

Keep in mind that other players in multiplayer will also observe this issue externally if a player follows these steps.

Additional context:
Running the hidearmor command again does fix the issue, Switchy attempts to work around this issue by trying to emulate the same behaviour, but this fails.

(as a side note, adding a public method that can set suppressed slots and update them would be super helpful!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants