Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob for candidates #312

Open
windymelt opened this issue Jan 10, 2023 · 2 comments
Open

Glob for candidates #312

windymelt opened this issue Jan 10, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@windymelt
Copy link

Is your feature request related to a problem? Please describe.

I'm going to use this action to update copyright information in template file (for XSlate template engine) using custom transform feature.

Of course, not all of template contains copyright year information. Currently I have to specify accurate file path that contains copyright year manually.

Describe the solution you'd like

If this action provides option that ignores regex mismatch, I will be able to use glob to specify target candidates.

Describe alternatives you've considered

Additional context

my transform is like this:

jobs:
  update-license-year:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
      - uses: FantasticFiasco/action-update-license-year@v2
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          path: templates/**/*.html
          transform: '(?<=<div class="copyright">Copyright &copy; )(?<from>\d{4})?(&ndash;)?(\d{4})?'

some of template contains following line:

<div class="copyright">Copyright &copy; 2005&ndash;2022 <a href="https://example.com/">Foobar Inc</a>. All Rights Reserved.</div>
@windymelt windymelt added the enhancement New feature or request label Jan 10, 2023
@github-actions
Copy link
Contributor

Hi there and welcome to this repository!

A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.

@FantasticFiasco
Copy link
Owner

Hi @windymelt! This sounds like a feature we could implement, but let's have this issue open to see if others might find this useful as well. With enough interest we'll implement it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants