-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use FlaUI to test all frameworks #193
Conversation
@@ -9,6 +9,9 @@ namespace MvvmDialogs.FrameworkDialogs.FolderBrowser | |||
public class FolderBrowserDialogSettingsTest | |||
{ | |||
[Test] | |||
#if NETCOREAPP3_0_OR_GREATER | |||
[Ignore("Need to fix for .Net Core and later")] | |||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FantasticFiasco here is a test that exposed a few missing properties in .net core 3 and above. Skipping the test to not break the build, but I believe this could be made into a separate issue.
Also as a result of this PR you can now use
Edit: tests can run in parallel too, which saves a lot of time, but some of them fail when that happens: msbuild
dotnet test --no-build |
@@ -1,72 +1,289 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//return windows.FirstOrDefault(x => x.Name == name)?.As<T>(); | ||
|
||
// Title is displaying wrong attribute | ||
return windows.FirstOrDefault(x => x.Title.ToLowerInvariant().Contains(name.ToLowerInvariant()))?.As<T>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be an issue with FlaUI. Need more investigation.
Migrating UI automation framework seems like a good idea! However, I'll be away on vacation during the weekend and also the next week, but I'll look into this PR when I get back the week after. |
No rush whatsoever. I'm going to Ottawa this weekend. #FreedomConvoy2022 |
I've looked at the project |
@FantasticFiasco how do you run them? I had one test fail after about 20 runs. I do get errors when I run these tests using With |
Closed in favor of #250 |
Description
Replace TestStack.White with FlaUI
Fixes #192
Checklist