Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SB3 HER Example #188

Closed
araffin opened this issue Apr 30, 2021 · 5 comments · Fixed by #189
Closed

SB3 HER Example #188

araffin opened this issue Apr 30, 2021 · 5 comments · Fixed by #189

Comments

@araffin
Copy link
Contributor

araffin commented Apr 30, 2021

Hello,
As SB2 is now deprecated, would you be interested in an updated version of the notebook that uses SB3?

I also found better hyper-parameters (the agent reaches 90% training success in 20 000 steps only) using TQC from the contrib repo.

@eleurent
Copy link
Collaborator

eleurent commented Apr 30, 2021

Hi @araffin, yes I would, thank you very much!

I already started switching to SB3 in a few scripts, but let's make it official :)

PS: wow I really need to check out that TQC algorithm!

@araffin
Copy link
Contributor Author

araffin commented Apr 30, 2021

I will do that (and probably will have to re-do it soon as the refactored version is almost ready: DLR-RM/stable-baselines3#351).

It should work well with SAC too (with the new hyperparams), but best results are with TQC.

@StarBaseOne
Copy link
Contributor

StarBaseOne commented May 1, 2021

@araffin super stuff. Waiting for the merge.
@eleurent yep TQC works nicely (great implementation from SB3) and outperforms SAC.

I've done some baseline experiments on HER with SB3 and Parking and Summon. I will be trying at somepoint to use SB3 benchmark for HER for all 4 algorithms (SAC,TD3,TQC & DDPG) for parking-v0 but if you have the params already done can you share them with me so I can re-run them soon?
her-baseline
her2

@araffin
Copy link
Contributor Author

araffin commented May 1, 2021

all hyperparameters are in the rl zoo: https://github.com/DLR-RM/rl-baselines3-zoo
(and i would recommend using it for doing experiments)

@StarBaseOne
Copy link
Contributor

StarBaseOne commented May 1, 2021

all hyperparameters are in the rl zoo: https://github.com/DLR-RM/rl-baselines3-zoo
(and i would recommend using it for doing experiments)

Yes thank you. I've been using your benchmark tool. It's pretty solid but haven't checked out from repo or updated it in several months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants