-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarkovVectorEnv does not set is_vector_env = True #216
Comments
I'm not 100% familiar with Gymnasium's vector environments, but I believe the distinction is that the vector environments in SuperSuit are intended to be used concatenated together (concat_vec_env), where they will return a list of observations, list of infos, etc. In the Gymnasium vector environments I believe they do the vectorization on the numpy level, meaning they will add a new dimension. So for example, I believe We intend to copy over the functionality of Gymnasium's vector environments to PettingZoo natively at some point, as it would be cleaner to have that versus these wrappers which aren't tested in the same CI as PettingZoo (so we could very easily mess something up in the future). It's much harder to maintain two separate libraries, so these wrappers will all eventually be moved and most likely changed quite a bit to be more efficient, etc. |
Running all of the tests locally they still pass with the So the point is basically that the wrapper flattens the environments and removes the names of agents. |
Just did some testing with that attribute added and it then when you try to use Gymnasium wrappers it throws errors for missing the attributes
|
Adding a test to ensure that these work, so thanks for the heads up about this. |
I was trying to set up a
pettingzoo
multi-agent environment for use as a vectorized environment through the wrappersupersuit.pettingzoo_env_to_vec_env_v1
and I realized thatMarkovVectorEnv
does not setìs_vector_env
toTrue
. Is this a design choice since this isn't a "real" multi-env class ? Or a bug? Or am I missing something?Here are my package versions:
The text was updated successfully, but these errors were encountered: