Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding info in CONTRIBUTING.md #66

Open
grdryn opened this issue Aug 24, 2013 · 1 comment
Open

Question regarding info in CONTRIBUTING.md #66

grdryn opened this issue Aug 24, 2013 · 1 comment
Assignees
Labels

Comments

@grdryn
Copy link

grdryn commented Aug 24, 2013

Hi,

I'm currently enjoying this book on my Kindle (bought from O'Reilly, thanks for making it), and I'm coming across some spelling and grammar issues. I'd happily submit pull requests for many of these if you'd like, but looking in CONTRIBUTING.md, I see:

Feel free to send your pull requests unless you want to fix English grammar.

The way I read/understand this, is that you don't want any pull requests related to spelling/grammar. Is that correct?

Thanks again for the book,
Gerard.

@ghost ghost assigned gAmUssA Aug 28, 2013
@gAmUssA
Copy link
Contributor

gAmUssA commented Aug 28, 2013

Gerard @grdryn,

Thanks for your comment! We're happy to hear that you enjoy reading your book!

Regarding contributions. Spelling and grammar issues is the job of O'Reilly editors. For us and for other readers more interesting would be to get feedback regarding actual content, errors and issues with technology or framework facts, source code issues and etc.
But if spelling and grammar bother you so bad then, please, submit pull request.

Cheers,
Vik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants