Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Guides. #69

Closed
simonv3 opened this issue Jul 21, 2014 · 5 comments
Closed

Style Guides. #69

simonv3 opened this issue Jul 21, 2014 · 5 comments

Comments

@simonv3
Copy link
Member

simonv3 commented Jul 21, 2014

It makes sense to create a series of code style guides for HTML/JS/CSS.

We can make our own, or just steal some from others.

CSS options: http://css-tricks.com/css-style-guides/
JS the Airbnb one is pretty good: https://github.com/airbnb/javascript

These could just be pages on the wiki for people to refer to, and could evolve as the codeset progresses.

It would also be a good place to define styles on top of the Foundation presets.

Thoughts?

@roryaronson
Copy link
Member

This sounds like a great idea. I think using someone else's work will be best to save us time, and we can always modify as needed.

@simonv3 can you throw your guides of choice onto the wiki?

@RickCarlino
Copy link
Contributor

We must enforce a good style guide. For Ruby, the defacto standard is this one: https://github.com/bbatsov/ruby-style-guide

I might throw Hound-CI up in a few days to automate the enforcement process.

@simonv3
Copy link
Member Author

simonv3 commented Jul 22, 2014

Great, I'll put those up when I get a chance. Rick, thanks for the link -
very useful as I'm starting to learn Ruby.
On Jul 22, 2014 1:36 AM, "Rick Carlino" notifications@github.com wrote:

We must enforce a good style guide. For Ruby, the defacto standard is
this one: https://github.com/bbatsov/ruby-style-guide

I might throw Hound-CI up in a few days to automate the enforcement
process.


Reply to this email directly or view it on GitHub
#69 (comment).

@simonv3
Copy link
Member Author

simonv3 commented Jul 25, 2014

Added style guides to the wiki. I didn't copy them over completely because I figured we didn't need to do that until we started needing to.

@simonv3 simonv3 closed this as completed Jul 25, 2014
@warpling
Copy link
Member

Awesome. Better than my wild west of style 😆. We should practice checking for these things in PRs.
(I'm a big fan of the Airbnb JS style guide too 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants