Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Farmware] Support multiple manifest args #838

Closed
gabrielburnworth opened this issue Jul 11, 2019 · 1 comment · Fixed by #860
Closed

[Farmware] Support multiple manifest args #838

gabrielburnworth opened this issue Jul 11, 2019 · 1 comment · Fixed by #860
Labels

Comments

@gabrielburnworth
Copy link
Contributor

FarmBot OS version

8.0.0-rc26

Relevant code

{cmd, _} = spawn_monitor(MuonTrap, :cmd, [exec, [manifest.args], opts])

Since the Farmware manifest args field is now a string instead of an array, the above line allows single args (such as "run.py") to work. To support multiple args in the string (such as "run.py -n 1"), a different approach must be used.

@ConnorRigby
Copy link
Contributor

{
 "package": "arg test",
 "language": "sh",
 "author": "FarmBot, Inc.",
 "description": "test",
 "farmware_manifest_version": "2.0.0",
 "package_version": "0.0.0",
 "farmbot_os_version_requirement": ">=0.0.0",
 "farmware_tools_version_requirement": ">=0.0.0",
 "url": "",
 "zip": "https://github.com/FarmBot-Labs/farmware_manifests/archive/master.zip",
 "executable": "sh",
 "args": "-c 'echo hello'"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants