Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Farmware] ImageUploader does not ensure images directory exists #841

Closed
gabrielburnworth opened this issue Jul 11, 2019 · 0 comments · Fixed by #853
Closed

[Farmware] ImageUploader does not ensure images directory exists #841

gabrielburnworth opened this issue Jul 11, 2019 · 0 comments · Fixed by #853
Labels

Comments

@gabrielburnworth
Copy link
Contributor

FarmBot OS version

8.0.0-rc26

To reproduce

Install and run a Farmware that saves an image to the image upload directory. For example, https://raw.githubusercontent.com/FarmBot-Labs/farmware_manifests/master/packages/take-photo/manifest_v2.json with a camera plugged in.

Relevant code

https://github.com/FarmBot/farmbot_os/blob/staging/farmbot_ext/lib/farmbot_ext/api/image_uploader.ex

(On the master branch, the directory was created via a mkdir_p call: https://github.com/FarmBot/farmbot_os/blob/1fe52021c71bfe068c2be09bd8ded99c211804f6/lib/farmbot/http/image_uploader.ex)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant