Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: SVG group includes origin point 0,0 #1197

Closed
slspencer opened this issue Oct 9, 2024 · 1 comment · Fixed by #1221
Closed

BUG: SVG group includes origin point 0,0 #1197

slspencer opened this issue Oct 9, 2024 · 1 comment · Fixed by #1221
Assignees
Labels

Comments

@slspencer
Copy link
Collaborator

slspencer commented Oct 9, 2024

  • Some bounding boxes for pattern pieces in an SVG export file are too big. These bounding boxes, or pattern piece XML groups, erroneously include the origin point which extends the pattern piece's bounding box up to the origin.
    These extra origin points have been in Seamly's SVG exports all along, they weren't recently introduced.

  • How To Reproduce the bug:
    Export an SVG layout from Seamly2D version 2024.10.8

  • What should have happened:
    All bounding boxes should be tight around each pattern piece's cut line.

  • Screenshots

  1. Looking at the SVG file in VSCode. Here is the XML group with a single child <path> element that has attribute d="M0,0":
<g stroke-opacity="1" stroke-linejoin="round" font-family="Arial" transform="matrix(1,0,0,1,0,0)" 
font-style="normal" fill="none" font-weight="400" stroke="#000000" stroke-width="1" 
stroke-linecap="round" font-size="10.6667">
   <path vector-effect="none" fill-rule="evenodd" d="M0,0"/>\
</g>

image

  1. Looking at the SVG file in Inkscape. The sleeve piece's bounding box extends up to origin point 0,0:
    image

  2. Looking at the SVG file in Inskcape, with [Shift][Cntrl][X] to view the XML. (Inkscape assigns id's to groups and elements. Seamly's SVG files don't have IDs)
    The sleeve piece's Inkscape assigned group id=g140, the origin point group id=g126 under g140. The group g140 is causing the bounding box to extend up to the origin point.
    image

  • What's your Desktop OS? Windows 10
  • What's your Seamly version from Help/About? Seamly 2024.10.8.1758
@slspencer
Copy link
Collaborator Author

This is the SVG file with extra origin points in some pattern piece groups.
The cutline and seamline will not display properly if you use a dark theme.
You can download this SVG file by right-clicking on the image below and selecting 'Save Image As'.


2024-10-09-b-Ald 2002 - Tailored Jkt V1-Std-Waist-Shape-FairCurve-ALD-PercentsV2_layout_01


@slspencer slspencer changed the title BUG: SVG group includes path with just a begin point BUG: SVG group includes origin point 0,0 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants