Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Latin-1 (ISO-8859-1) via Async parser #59

Closed
cowtowncoder opened this issue Apr 4, 2018 · 5 comments
Closed

Support Latin-1 (ISO-8859-1) via Async parser #59

cowtowncoder opened this issue Apr 4, 2018 · 5 comments
Milestone

Comments

@cowtowncoder
Copy link
Member

(note: sort of related to #50)

Up to 1.1.0, only UTF-8 and US-ASCII (7-bit Ascii) encodings are supported by async parser.
But since Latin-1 is Unicode value compatible with UTF-8 (even though differing in encoding details), it should be possible and relatively easy to allow that too.

@cowtowncoder cowtowncoder added this to the 0.9.11 milestone Apr 4, 2018
@adamretter
Copy link
Contributor

Thank you very much @cowtowncoder :-)

@adamretter
Copy link
Contributor

@cowtowncoder Just wondering, did this make it into a release? I am trying version 1.1.0 and still seeing:

Unsupported encoding 'ISO-8859-1': only UTF-8 and US-ASCII support by async parser
 at [row,col {unknown-source}]: [1,42]
com.fasterxml.aalto.WFCException: Unsupported encoding 'ISO-8859-1': only UTF-8 and US-ASCII support by async parser
 at [row,col {unknown-source}]: [1,42]
	at com.fasterxml.aalto.in.XmlScanner.reportInputProblem(XmlScanner.java:1333)
	at com.fasterxml.aalto.async.AsyncByteScanner.verifyAndSetXmlEncoding(AsyncByteScanner.java:359)

@cowtowncoder cowtowncoder modified the milestones: 0.9.11, 1.1.1 Sep 18, 2018
@cowtowncoder
Copy link
Member Author

Looks like it didn't; will be in 1.1.1, which I hope I can get out soon. Life's bit hectic right now :)

@adamretter
Copy link
Contributor

No worries. Thanks for letting me know :-). Best wishes @cowtowncoder

@cowtowncoder
Copy link
Member Author

@adamretter Pushing 1.1.1 release out now with just this one fix, should be at MC in an hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants