Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InternalNodeMapper needs to support setting JsonMapper #4017

Closed
pjfanning opened this issue Jul 8, 2023 · 1 comment
Closed

InternalNodeMapper needs to support setting JsonMapper #4017

pjfanning opened this issue Jul 8, 2023 · 1 comment
Labels
to-evaluate Issue that has been received but not yet evaluated

Comments

@pjfanning
Copy link
Member

Relates to #4016

The broken test in DeepJsonNodeSerTest is because of the jsonNode and the toString call. That call uses InternalNodeMapperwhich has its own hardcoded JsonMapper. That JsonMapper instance uses the default StreamWriteConstraints. The jsonNode has data that exceeds the max default depth allowed.
@pjfanning pjfanning added the to-evaluate Issue that has been received but not yet evaluated label Jul 8, 2023
pjfanning referenced this issue Jul 9, 2023
@cowtowncoder
Fix (now-)failing Deep JsonNode ser test
ecaf95c
@pjfanning pjfanning mentioned this issue Jul 9, 2023
Closed
@cowtowncoder
Copy link
Member

No, there is no need to change these settings -- this class is only ever to be used for JsonNode.toString() and as such is expected not to be configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
to-evaluate Issue that has been received but not yet evaluated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cowtowncoder @pjfanning