This repository has been archived by the owner on Jan 22, 2019. It is now read-only.
Add CsvParser.Feature.ALLOW_TRAILING_COMMA to allow enforcing strict handling
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the behavior allows there to be a single extraneous data column that is empty. This is normally harmless, however, external tools that expect the same number of data columns as header columns will complain when this extraneous column is encountered. The fix is to make this feature explicit and allow for it to be disabled. This patch retains backwards compatibility by enabling the feature by default.
|
@nickbabcock Thank you! I will have to think about this a bit (just came back from vacation, hence the delay), but at high level sounds reasonable. |
|
Ok, looks good, will merge. |
cowtowncoder
changed the title
CsvParser.Feature.ALLOW_TRAILING_COMMA to allow enforcing strict handling
cowtowncoder
added a commit
that referenced
this pull request
Jan 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the behavior allows there to be a single extraneous data column
that is empty. This is normally harmless, however, external tools that
expect the same number of data columns as header columns will complain
when this extraneous column is encountered.
The fix is to make this feature explicit and allow for it to be disabled.
This patch retains backwards compatibility by enabling the feature by
default.
I consider this a bugfix, but I may not be able to convince you 😄