Skip to content

Commit f5664cf

Browse files
cowtowncodercowtowncoder
authored
Fix #628 for 3.1 (#633)
1 parent 45a92ac commit f5664cf

File tree

7 files changed

+82
-14
lines changed

7 files changed

+82
-14
lines changed

‎avro/pom.xml‎

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,21 @@ abstractions.
3434
</properties>
3535

3636
<dependencies>
37-
<!-- Core deps from parent -->
37+
<!-- Depend on Jackson core components -->
38+
<dependency>
39+
<groupId>com.fasterxml.jackson.core</groupId>
40+
<artifactId>jackson-annotations</artifactId>
41+
</dependency>
42+
<dependency>
43+
<groupId>tools.jackson.core</groupId>
44+
<artifactId>jackson-core</artifactId>
45+
</dependency>
46+
<dependency>
47+
<groupId>tools.jackson.core</groupId>
48+
<artifactId>jackson-databind</artifactId>
49+
</dependency>
3850

51+
<!-- Also on Apache Avro codec for some encoding/decoding -->
3952
<dependency>
4053
<groupId>org.apache.avro</groupId>
4154
<artifactId>avro</artifactId>
@@ -57,7 +70,7 @@ abstractions.
5770
</dependency>
5871

5972
<!-- 14-Jan-2025, joohyukkim: [JSTEP-10] Most tests have been migrated to
60-
JUnit5, but except `avro` modules `/interop` tests
73+
JUnit5, except `avro` modules `/interop` tests
6174
-->
6275
<dependency>
6376
<groupId>junit</groupId>

‎cbor/pom.xml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,22 @@ encoded data using Jackson abstractions (streaming API, data binding, tree model
3838
</properties>
3939

4040
<dependencies>
41+
<!-- We depend on Jackson core components; annotations optionally/for tests -->
42+
<dependency>
43+
<groupId>tools.jackson.core</groupId>
44+
<artifactId>jackson-core</artifactId>
45+
</dependency>
46+
<dependency>
47+
<groupId>tools.jackson.core</groupId>
48+
<artifactId>jackson-databind</artifactId>
49+
</dependency>
50+
51+
<!-- for testing we need annotations -->
52+
<dependency>
53+
<groupId>com.fasterxml.jackson.core</groupId>
54+
<artifactId>jackson-annotations</artifactId>
55+
<scope>provided</scope>
56+
</dependency>
4157
</dependencies>
4258

4359
<build>

‎ion/pom.xml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,20 @@ tree model)
3434
</properties>
3535

3636
<dependencies>
37+
<!-- Depend on Jackson core components -->
38+
<dependency>
39+
<groupId>com.fasterxml.jackson.core</groupId>
40+
<artifactId>jackson-annotations</artifactId>
41+
</dependency>
42+
<dependency>
43+
<groupId>tools.jackson.core</groupId>
44+
<artifactId>jackson-core</artifactId>
45+
</dependency>
46+
<dependency>
47+
<groupId>tools.jackson.core</groupId>
48+
<artifactId>jackson-databind</artifactId>
49+
</dependency>
50+
3751
<!-- actual decoding by core streaming Ion lib -->
3852
<dependency>
3953
<groupId>com.amazon.ion</groupId>

‎pom.xml‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,7 @@
5353

5454
<dependencies>
5555
<!-- all dataformats extend core and databind, annotations; include here -->
56-
<dependency>
57-
<groupId>com.fasterxml.jackson.core</groupId>
58-
<artifactId>jackson-annotations</artifactId>
59-
</dependency>
60-
<dependency>
61-
<groupId>tools.jackson.core</groupId>
62-
<artifactId>jackson-core</artifactId>
63-
</dependency>
64-
<dependency>
65-
<groupId>tools.jackson.core</groupId>
66-
<artifactId>jackson-databind</artifactId>
67-
</dependency>
56+
<!-- 01-Nov-2025, tatu: [dataformats-binary#628] No longer -->
6857

6958
<!-- 11-Jan-2025, joohyukkim: For JSTEP-10, migrate to JUnit5 -->
7059
<dependency>

‎protobuf/pom.xml‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,23 @@ abstractions.
3636
</properties>
3737

3838
<dependencies>
39+
<!-- We depend on Jackson core components; annotations optionally/for tests -->
40+
<dependency>
41+
<groupId>tools.jackson.core</groupId>
42+
<artifactId>jackson-core</artifactId>
43+
</dependency>
44+
<dependency>
45+
<groupId>tools.jackson.core</groupId>
46+
<artifactId>jackson-databind</artifactId>
47+
</dependency>
48+
49+
<!-- for testing we need annotations -->
50+
<dependency>
51+
<groupId>com.fasterxml.jackson.core</groupId>
52+
<artifactId>jackson-annotations</artifactId>
53+
<scope>provided</scope>
54+
</dependency>
55+
3956
<!-- uses protostuff libs for parsing, generation -->
4057
<dependency>
4158
<groupId>com.squareup</groupId>

‎release-notes/VERSION‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ implementations)
2323
(requested by Andy W)
2424
#623: (ion) Upgrade `ion-java` dep to 1.11.11 (from 1.11.10)
2525
(requested by @Shaurya0108)
26+
#628: (avro, cbor, ion, protobuf, smile) Uncommon parent pom dependency
27+
configuration in Jackson 2.20/3.0
28+
(reported by Josh C)
2629
#629: (ion) Unnecessary `IOException` in `IonObjectMapper` method signatures
2730
(fix contributed by Michael L)
2831

‎smile/pom.xml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,22 @@ tree model)
3434
</properties>
3535

3636
<dependencies>
37+
<!-- We depend on Jackson core components; annotations optionally/for tests -->
38+
<dependency>
39+
<groupId>tools.jackson.core</groupId>
40+
<artifactId>jackson-core</artifactId>
41+
</dependency>
42+
<dependency>
43+
<groupId>tools.jackson.core</groupId>
44+
<artifactId>jackson-databind</artifactId>
45+
</dependency>
46+
47+
<!-- for testing we need annotations -->
48+
<dependency>
49+
<groupId>com.fasterxml.jackson.core</groupId>
50+
<artifactId>jackson-annotations</artifactId>
51+
<scope>provided</scope>
52+
</dependency>
3753
</dependencies>
3854

3955
<build>

0 commit comments

Comments
 (0)