Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avro] Rename VisitorFormatWrapperImpl to AvroFormatVisitorWrapper in 2.14 or 3.0 #294

Open
MichalFoksa opened this issue Aug 15, 2021 · 0 comments
Labels

Comments

@MichalFoksa
Copy link
Contributor

VisitorFormatWrapperImpl class name is unfortunate. It makes sense to rename it into something more descriptive, for example AvroFormatVisitorWrapper.

Implementation in 2.13:

public class VisitorFormatWrapperImpl
    implements JsonFormatVisitorWrapper

Citation from #292 comment:

Maybe it would make sense to also file a follow-up issue about actual renaming (of VisitorFormatWrapperImpl ) like you suggested first (to AvroFormatVisitorWrapper).
I'd have to think if it actually could go in 2.14, after all, or at least in 3.0.

Question is, in which release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants