Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZonedDateTime documentation seems to be incorrect #170

Closed
AceHack opened this issue Apr 9, 2020 · 4 comments
Closed

ZonedDateTime documentation seems to be incorrect #170

AceHack opened this issue Apr 9, 2020 · 4 comments
Labels
documentation Issue that documentation improvements could solve or alleviate

Comments

@AceHack
Copy link

AceHack commented Apr 9, 2020

It says:
https://github.com/FasterXML/jackson-modules-java8/tree/master/datetime

For string representation default formats for deserialization are:

Java type Format
ZonedDateTime DateTimeFormatter.ISO_ZONED_DATE_TIME

But in the code I see:

// ISO_ZONED_DATE_TIME is not the ISO format, it is an extension of it
this(DateTimeFormatter.ISO_OFFSET_DATE_TIME);

@kupci kupci added the documentation Issue that documentation improvements could solve or alleviate label Apr 9, 2020
@kupci
Copy link
Member

kupci commented Apr 9, 2020

Yes, and the comment could be improved too. A little ambiguous though perhaps trying to explain why ISO_OFFSET_DATE_TIME is used and not ISO_ZONED_DATE_TIME.

@cowtowncoder cowtowncoder added the hacktoberfest Issue related to Hactoberfest2020 activities, eligible for additional rewards label Sep 30, 2020
@mydata
Copy link
Contributor

mydata commented Oct 13, 2022

@cowtowncoder please confirm
As per the issue description documentation seems to be incorrect. Is that correct? or implementation needs to be updated to match the documentation?

@cowtowncoder
Copy link
Member

@mydata Generally documentation should match implementation unless indicated otherwise. So I'd start with that.

@winfriedgerlach
Copy link

winfriedgerlach commented Nov 8, 2024

@cowtowncoder @pjfanning as far as I can see the documentation was fixed a long time ago with 92c9e0d and the code was also modified to include a more extensive comment why ISO_OFFSET_DATE_TIME is used. IMHO this ticket can be closed.

@cowtowncoder cowtowncoder removed the hacktoberfest Issue related to Hactoberfest2020 activities, eligible for additional rewards label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue that documentation improvements could solve or alleviate
Projects
None yet
Development

No branches or pull requests

5 participants