-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move msgpack and pyyaml to extras #7
Comments
@rominf I don't agree with you. If i make dependencies optional, it will break compatibility for those who already use |
Can you explain why do you think "it will break compatibility for those who already use $ pip install -U mashumaro[msgpack,yaml] That can be documented. Also, how can I tell |
You're totally wrong here. The users should be able to install the current major version of I will consider to make |
I don't agree with you, in my opinion it's a minor issue for users. But anyway, you are the creator of the library and I respect your opinion.
Nice to hear. I hope you will do it, as it will attract more users. |
my 2c: I really like mashumaro, I was thinking of replacing my use of cattrs with it, but decided not to because it forces my application to depend on msgpack and yaml which I am not planning on using. Please make them extras! Thanks |
msgpack and pyyaml are going to be extra requirements in the next 3.0 version. The existing mixins will be imported from |
And finally these two packages are optional in 3.0. |
I want to use the library for conversion to and from dict only. So, I don't like that when I install the library
msgpack
andpyyaml
are installed.Here is the relevant part of documentation: https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies
The text was updated successfully, but these errors were encountered: