Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not using laravel config Authentication Model name? #1

Open
pajooh opened this issue Apr 8, 2014 · 1 comment
Open

why not using laravel config Authentication Model name? #1

pajooh opened this issue Apr 8, 2014 · 1 comment

Comments

@pajooh
Copy link

pajooh commented Apr 8, 2014

in app/config/auth.php, there is a 'model' property, using this is more flexible than current hardcoded user model in Comment model:

    public function user()
    {
        return $this->belongsTo('User');
    }

also, it is assumed that the user model have to has username property, getting this property name as config option makes this package workable with custom user models like Sentry, etc.

@neilcrookes
Copy link
Contributor

Sounds like a good idea to me. Can you send me a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants