Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sendRequest & sendRequest2 #48

Open
FelicianoTech opened this issue Nov 12, 2020 · 0 comments
Open

Improve sendRequest & sendRequest2 #48

FelicianoTech opened this issue Nov 12, 2020 · 0 comments

Comments

@FelicianoTech
Copy link
Owner

sendRequest & sendRequest2 are two functions that do almost exactly the same thing. The former is for the unique Docker Hub specific API and the second for the generic Docker registry API.

This is inefficient and needs to be improved. Also, the latter function supports tokens but not proper authenticated tokens. This needs to be supported as well.

Lastly, each Docker module file stores it's entire URL that it needs for calls. This needs to be changed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant