-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature suggestion: default to FQDN instead of top level domain in creating a rule #1304
Comments
Thanks for the report. Unfortunately the popup is already packed up with too many features and is too slow. I would rather wait for more supporters before considering this. |
@FelisCatus i'm not suggesting you should add a checkbox in the popup, but someting in the main setup, that would be loaded before the popup is launched, wouldn't that function and the IF loop be minimal resource wise ? somethinng like.
? |
it would require a read from localStorage on Chrome and message back and forth between the popup page and the background page on Firefox. Either has some performance impacts, but as long as it is performed lazily when the form is open, it will not impact user experience much. I'm open to PR for this one. Just make sure the read is NOT performed when the popup is first opened as that would slow down the opening of the popup. |
Still not implemented? It would be a very useful feature. |
Hi,
Add condition will take the main domain (example.com) when constructing a new rule by default.
In my work i have to set different proxies for multiple subdomains, so having the rule creation default to the fqdn makes alot more sense.
could you add a checkbox in button to select either behaviour ?
Thanks !
Roy
The text was updated successfully, but these errors were encountered: