Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken icon in Firefox 58.0 #1357

Closed
anon88391 opened this issue Jan 20, 2018 · 5 comments
Closed

Broken icon in Firefox 58.0 #1357

anon88391 opened this issue Jan 20, 2018 · 5 comments

Comments

@anon88391
Copy link

The extension icon is bugged and entirely white in the newest Firefox 58.0.
https://i.imgur.com/NxeinR5.png

@FelisCatus
Copy link
Owner

Could you please right click on the icon and select "Save error log"? Having the log here definitely helps.

@haiwx
Copy link

haiwx commented Jan 23, 2018

I noticed, because of privacy.resistFingerprinting , you can chang it to false in about:config.

Firefox 58 warns you if sites use Canvas image data

@FelisCatus 扩展图标是用了 Canvas 相关的东西吗?

@FelisCatus
Copy link
Owner

FelisCatus commented Jan 27, 2018

SwitchyOmega is using canvas to draw icons and apparently that's what broke it. A canvas is needed because the icons can come in any color combinations.

In other browsers blocking canvas data, SwitchyOmega will fall back to the static, non-color-changing icon if it throws when trying to access canvas. Firefox is the first browser I've ever seen to return a blank image instead and I don't know what to do now.

Please see the Firefox issue here: https://bugzilla.mozilla.org/show_bug.cgi?id=1412961

@FelisCatus
Copy link
Owner

FelisCatus commented Jan 28, 2018

In v2.5.10, the SwitchyOmega icon will stay the default blue icon if you have privacy.resistFingerprinting set to true. It won't change based on profile colors but at least it won't become empty.

Please subscribe to #1362 for the real solution.

@FelisCatus
Copy link
Owner

I believe this is fixed in Firefox 62. Note that it can still fail on modified / flagged versions of Chrome that disables canvas even for extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants