Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--max_n value as a fraction #137

Closed
bounlu opened this issue Aug 11, 2022 · 4 comments
Closed

--max_n value as a fraction #137

bounlu opened this issue Aug 11, 2022 · 4 comments

Comments

@bounlu
Copy link

bounlu commented Aug 11, 2022

--max-n parameter in cutadapt accepts a fraction of read length in addition to the number of Ns, however, trim_galore seems to only accept as counts for this parameter. How to make trim_galore compatible with the fraction? What happens if I pass a value of fraction to trim_galore?

trim_galore:

--max_n COUNT           The total number of Ns (as integer) a read may contain before it will be removed altogether.
                        In a paired-end setting, either read exceeding this limit will result in the entire
                        pair being removed from the trimmed output files.

cutadapt:

--max-n COUNT           Discard reads with more than COUNT 'N' bases. If COUNT is a number between 0 and 1,
                        it is interpreted as a fraction of the read length.
@bounlu bounlu changed the title --max-n value as a fraction --max_n value as a fraction Aug 11, 2022
@FelixKrueger
Copy link
Owner

I suppose this shouldn't be too hard to implement, is this something you would require?

@FelixKrueger
Copy link
Owner

I have now had a go at implementing this (e6ed90a), can you try and clone the dev branch and see if it works for you?

@bounlu
Copy link
Author

bounlu commented Aug 12, 2022

Really appreciate the quick effort, however I have switched to cutadapt for more flexible options overall.

@FelixKrueger
Copy link
Owner

That's fine, maybe someone else will want it at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants