-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make femtolisp a submodule #3
Comments
I agree. I would like to get rid of this altogther and have the makefile pull the femtolisp code direct from Jeff repository and ensure any of our changes were put into seperate files etc. Then have a make target called femtolisp which grabbed, built it and applied our changes. I'm not that familiar with our changes to femtolisp as lucas did the work here. But I am going to go through them in detail at some point. Also would like any changes / improvements we have made to femtolisp to be be a pull request to Jeff's codebase. Eg the maths code needs to go into its own math.c file and push to femtolisp. BTW I will invite you to the FemtoEmacsDevs chat room on gitter. |
I would recommend keeping your own fork of Jeff's repository, cases where Jeff's refuses to merge I'm already trying to "merge" addins from Chi |
https://github.com/lambdaconservatory/femtolisp is soliciting patches from FemtoLisp users. I'm happy to give write access to anyone who wants it. |
Update: I now manage the Femto repository at: I will take future updates on that repository. I abandonned using FemtoLisp and use a tinyLisp implementation that is part of the actual codebase. The code was public domain and I was free to incorporate it fully into Femto. I also extended the TinyLisp to support strings. The result is very effective and stable. Plus we dont have to compile 12K of FemtoLisp with 2K of Editor code lines. |
It makes sense to have JeffBezanson/femtolisp as a submodule of
FemtoEmacs
, since it is a third party project, it makes lot easierto integrate upstream changes into
FemtoEmacs
, I suggestincorparate the current changes made to
FemtoEmacs/femtolisp
into your own fork of JeffBezanson/femtolisp, and then have it as the
submodule of
FemtoEmacs
.I suggest this approach:
named
femtoo-emacs
for instance.FemtoEmacs/femtolisp
intothe branch.
FemtoEmacs/femtolisp
and then add your own fork asa
FemtoEmacs
submodule.Chi
The text was updated successfully, but these errors were encountered: