Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make femtolisp a submodule #3

Open
chigoncalves opened this issue Sep 15, 2016 · 4 comments
Open

Make femtolisp a submodule #3

chigoncalves opened this issue Sep 15, 2016 · 4 comments

Comments

@chigoncalves
Copy link
Contributor

It makes sense to have JeffBezanson/femtolisp as a submodule of
FemtoEmacs, since it is a third party project, it makes lot easier
to integrate upstream changes into FemtoEmacs, I suggest
incorparate the current changes made to FemtoEmacs/femtolisp
into your own fork of JeffBezanson/femtolisp, and then have it as the
submodule of FemtoEmacs.

I suggest this approach:

  • Create a new branch in FemtoEmacs/femtolisp, this branch can be
    named femtoo-emacs for instance.
  • Incorporate current changes from FemtoEmacs/femtolisp into
    the branch.
  • Delete FemtoEmacs/femtolisp and then add your own fork as
    a FemtoEmacs submodule.

Chi

@chigoncalves chigoncalves changed the title Make femtolisp a sub Make femtolisp a submodule Sep 15, 2016
@hughbarney
Copy link
Collaborator

hughbarney commented Sep 15, 2016

I agree. I would like to get rid of this altogther and have the makefile pull the femtolisp code direct from Jeff repository and ensure any of our changes were put into seperate files etc. Then have a make target called femtolisp which grabbed, built it and applied our changes. I'm not that familiar with our changes to femtolisp as lucas did the work here. But I am going to go through them in detail at some point.

Also would like any changes / improvements we have made to femtolisp to be be a pull request to Jeff's codebase. Eg the maths code needs to go into its own math.c file and push to femtolisp.

BTW I will invite you to the FemtoEmacsDevs chat room on gitter.
Hugh

@chigoncalves
Copy link
Contributor Author

I would like to get rid of this altogther and have the makefile pull the femtolisp code direct from Jeff repository and ensure any of our changes were put into seperate files etc.

I would recommend keeping your own fork of Jeff's repository, cases where Jeff's refuses to merge
changes from your fork.

I'm already trying to "merge" addins from Femto-Emacs/femtolisp to my fork of femtolisp.

Chi

@lassik
Copy link

lassik commented May 22, 2021

https://github.com/lambdaconservatory/femtolisp is soliciting patches from FemtoLisp users. I'm happy to give write access to anyone who wants it.

@hughbarney
Copy link
Collaborator

Update:

I now manage the Femto repository at:
https://github.com/hughbarney/femto/blob/master/README.md

I will take future updates on that repository.

I abandonned using FemtoLisp and use a tinyLisp implementation that is part of the actual codebase. The code was public domain and I was free to incorporate it fully into Femto. I also extended the TinyLisp to support strings. The result is very effective and stable. Plus we dont have to compile 12K of FemtoLisp with 2K of Editor code lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants