Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field dim is not necessarily spatial dim #616

Closed
koehlerson opened this issue Mar 10, 2023 · 4 comments · Fixed by #764
Closed

Field dim is not necessarily spatial dim #616

koehlerson opened this issue Mar 10, 2023 · 4 comments · Fixed by #764
Labels
bug good first issue Something to work on as a new contributor!

Comments

@koehlerson
Copy link
Member

When creating *VectorValues it is assumed that the field has the same dimensions as the spatial ones, which is not always the case, e.g. when evaluating gradient fields

@termi-official
Copy link
Member

Similar for the other dimensions. Reference element dimension is not necessarily spatial dimension and field dimension is also decoupled from vectorization dimension of scalar valued basis functions.

E.g. Nedelec has field dimension D, but only one basis function, wheras vectorized Lagrange has field dimension D with D basis functions per entity.

@termi-official
Copy link
Member

termi-official commented Mar 10, 2023

Relates to #569 and #398

@fredrikekre
Copy link
Member

fredrikekre commented May 20, 2023

Fixed by #694 + #651 I think? Reopen/comment if not.

@termi-official
Copy link
Member

termi-official commented May 21, 2023

Not fully fixed yet. This code still fails

using Ferrite
grid = generate_grid(Quadrilateral, (2, 2))
dim = 2
ip = Lagrange{RefQuadrilateral, 1}()
qr_face = FaceQuadratureRule{RefQuadrilateral}(2)
facevalues = FaceValues(qr_face, ip^3);

because the embedded values was mostly about getting CellValues in place. But should be easy to fix.

Edit 1: Marked the remaining fix as a good first issue. Basically we have to mirror the functionality of the new CellValues constructors into FaceValues.

Edit2: New interface.

@termi-official termi-official added the good first issue Something to work on as a new contributor! label May 21, 2023
@KnutAM KnutAM linked a pull request Jul 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Something to work on as a new contributor!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants