Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different signedness comparison warning #70

Open
dimalvovs opened this issue Dec 8, 2023 · 0 comments
Open

Different signedness comparison warning #70

dimalvovs opened this issue Dec 8, 2023 · 0 comments
Labels
core enhancement New feature or request

Comments

@dimalvovs
Copy link
Contributor

Match the type of integers to avoid potential problems flagged in the warning below that gets generated during build:

src/bindings.cpp: In lambda function:
src/bindings.cpp:309:35: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  309 |                 for (int i = 0; i < m.nRow(); i++) {
      |                                 ~~^~~~~~~~~~
src/bindings.cpp:310:39: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  310 |                     for (int j = 0; j < m.nCol(); j++) {
      |                                     ~~^~~~~~~~~~
@dimalvovs dimalvovs added enhancement New feature or request core labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant