Skip to content

Commit ac75f13

Browse files
feat(client): add convenience overloads for some methods
1 parent a7638ae commit ac75f13

File tree

4 files changed

+78
-16
lines changed

4 files changed

+78
-16
lines changed

finch-java-core/src/main/kotlin/com/tryfinch/api/services/async/sandbox/jobs/ConfigurationServiceAsync.kt

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,24 @@ interface ConfigurationServiceAsync {
5656
requestOptions: RequestOptions = RequestOptions.none(),
5757
): CompletableFuture<SandboxJobConfiguration>
5858

59+
/** @see update */
60+
fun update(
61+
sandboxJobConfiguration: SandboxJobConfiguration,
62+
requestOptions: RequestOptions = RequestOptions.none(),
63+
): CompletableFuture<SandboxJobConfiguration> =
64+
update(
65+
SandboxJobConfigurationUpdateParams.builder()
66+
.sandboxJobConfiguration(sandboxJobConfiguration)
67+
.build(),
68+
requestOptions,
69+
)
70+
71+
/** @see update */
72+
fun update(
73+
sandboxJobConfiguration: SandboxJobConfiguration
74+
): CompletableFuture<SandboxJobConfiguration> =
75+
update(sandboxJobConfiguration, RequestOptions.none())
76+
5977
/**
6078
* A view of [ConfigurationServiceAsync] that provides access to raw HTTP responses for each
6179
* method.
@@ -112,5 +130,23 @@ interface ConfigurationServiceAsync {
112130
params: SandboxJobConfigurationUpdateParams,
113131
requestOptions: RequestOptions = RequestOptions.none(),
114132
): CompletableFuture<HttpResponseFor<SandboxJobConfiguration>>
133+
134+
/** @see update */
135+
fun update(
136+
sandboxJobConfiguration: SandboxJobConfiguration,
137+
requestOptions: RequestOptions = RequestOptions.none(),
138+
): CompletableFuture<HttpResponseFor<SandboxJobConfiguration>> =
139+
update(
140+
SandboxJobConfigurationUpdateParams.builder()
141+
.sandboxJobConfiguration(sandboxJobConfiguration)
142+
.build(),
143+
requestOptions,
144+
)
145+
146+
/** @see update */
147+
fun update(
148+
sandboxJobConfiguration: SandboxJobConfiguration
149+
): CompletableFuture<HttpResponseFor<SandboxJobConfiguration>> =
150+
update(sandboxJobConfiguration, RequestOptions.none())
115151
}
116152
}

finch-java-core/src/main/kotlin/com/tryfinch/api/services/blocking/sandbox/jobs/ConfigurationService.kt

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,22 @@ interface ConfigurationService {
5555
requestOptions: RequestOptions = RequestOptions.none(),
5656
): SandboxJobConfiguration
5757

58+
/** @see update */
59+
fun update(
60+
sandboxJobConfiguration: SandboxJobConfiguration,
61+
requestOptions: RequestOptions = RequestOptions.none(),
62+
): SandboxJobConfiguration =
63+
update(
64+
SandboxJobConfigurationUpdateParams.builder()
65+
.sandboxJobConfiguration(sandboxJobConfiguration)
66+
.build(),
67+
requestOptions,
68+
)
69+
70+
/** @see update */
71+
fun update(sandboxJobConfiguration: SandboxJobConfiguration): SandboxJobConfiguration =
72+
update(sandboxJobConfiguration, RequestOptions.none())
73+
5874
/**
5975
* A view of [ConfigurationService] that provides access to raw HTTP responses for each method.
6076
*/
@@ -114,5 +130,25 @@ interface ConfigurationService {
114130
params: SandboxJobConfigurationUpdateParams,
115131
requestOptions: RequestOptions = RequestOptions.none(),
116132
): HttpResponseFor<SandboxJobConfiguration>
133+
134+
/** @see update */
135+
@MustBeClosed
136+
fun update(
137+
sandboxJobConfiguration: SandboxJobConfiguration,
138+
requestOptions: RequestOptions = RequestOptions.none(),
139+
): HttpResponseFor<SandboxJobConfiguration> =
140+
update(
141+
SandboxJobConfigurationUpdateParams.builder()
142+
.sandboxJobConfiguration(sandboxJobConfiguration)
143+
.build(),
144+
requestOptions,
145+
)
146+
147+
/** @see update */
148+
@MustBeClosed
149+
fun update(
150+
sandboxJobConfiguration: SandboxJobConfiguration
151+
): HttpResponseFor<SandboxJobConfiguration> =
152+
update(sandboxJobConfiguration, RequestOptions.none())
117153
}
118154
}

finch-java-core/src/test/kotlin/com/tryfinch/api/services/async/sandbox/jobs/ConfigurationServiceAsyncTest.kt

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ package com.tryfinch.api.services.async.sandbox.jobs
55
import com.tryfinch.api.TestServerExtension
66
import com.tryfinch.api.client.okhttp.FinchOkHttpClientAsync
77
import com.tryfinch.api.models.SandboxJobConfiguration
8-
import com.tryfinch.api.models.SandboxJobConfigurationUpdateParams
98
import org.junit.jupiter.api.Test
109
import org.junit.jupiter.api.extension.ExtendWith
1110

@@ -38,13 +37,9 @@ internal class ConfigurationServiceAsyncTest {
3837

3938
val sandboxJobConfigurationFuture =
4039
configurationServiceAsync.update(
41-
SandboxJobConfigurationUpdateParams.builder()
42-
.sandboxJobConfiguration(
43-
SandboxJobConfiguration.builder()
44-
.completionStatus(SandboxJobConfiguration.CompletionStatus.COMPLETE)
45-
.type(SandboxJobConfiguration.Type.DATA_SYNC_ALL)
46-
.build()
47-
)
40+
SandboxJobConfiguration.builder()
41+
.completionStatus(SandboxJobConfiguration.CompletionStatus.COMPLETE)
42+
.type(SandboxJobConfiguration.Type.DATA_SYNC_ALL)
4843
.build()
4944
)
5045

finch-java-core/src/test/kotlin/com/tryfinch/api/services/blocking/sandbox/jobs/ConfigurationServiceTest.kt

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ package com.tryfinch.api.services.blocking.sandbox.jobs
55
import com.tryfinch.api.TestServerExtension
66
import com.tryfinch.api.client.okhttp.FinchOkHttpClient
77
import com.tryfinch.api.models.SandboxJobConfiguration
8-
import com.tryfinch.api.models.SandboxJobConfigurationUpdateParams
98
import org.junit.jupiter.api.Test
109
import org.junit.jupiter.api.extension.ExtendWith
1110

@@ -37,13 +36,9 @@ internal class ConfigurationServiceTest {
3736

3837
val sandboxJobConfiguration =
3938
configurationService.update(
40-
SandboxJobConfigurationUpdateParams.builder()
41-
.sandboxJobConfiguration(
42-
SandboxJobConfiguration.builder()
43-
.completionStatus(SandboxJobConfiguration.CompletionStatus.COMPLETE)
44-
.type(SandboxJobConfiguration.Type.DATA_SYNC_ALL)
45-
.build()
46-
)
39+
SandboxJobConfiguration.builder()
40+
.completionStatus(SandboxJobConfiguration.CompletionStatus.COMPLETE)
41+
.type(SandboxJobConfiguration.Type.DATA_SYNC_ALL)
4742
.build()
4843
)
4944

0 commit comments

Comments
 (0)