-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve performance of a crypt marshaller (ostracon#177) #2
Comments
This is a PR for performance test and this PR says
If we need this improvement in the main branch, it may need other PRs to improve it. |
Performance seems to be improved, so we can create a PR after considering what we need for main branch. |
I think it is worth merging into the main form the view point of performance. |
@loloicci
As for the further tests mentioned in the PR, I don't know what to do. |
By the way, the relevant parts of the crypto package have changed significantly in cometbft v0.38.0. Ostracon#177 doesn't seem to be necessary since it returns a byte slice directly instead of an amino-marshalled byte slice. |
Thank you @Mdaiki0730 . I close this issue. |
The subject of the triage:
The text was updated successfully, but these errors were encountered: