Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some timing info log (ostracon#324) #51

Closed
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 4 comments
Closed
Tracked by #1

Add some timing info log (ostracon#324) #51

0Tech opened this issue Nov 1, 2023 · 4 comments

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

The subject of the triage:

@loloicci
Copy link

loloicci commented Nov 6, 2023

Finschia/ostracon#324 adds some time info to info logs. This looks to be able to be merged into cometbft and to be suggested upstream.

@loloicci loloicci changed the title Triage on ostracon#324 Add some timing info log (ostracon#324) Nov 15, 2023
@Mdaiki0730
Copy link
Member

@loloicci
Do you know the background behind why it became necessary to log this information at info level?

@loloicci
Copy link

loloicci commented Dec 7, 2023

In our team, this info log is not used by other backends/middlewares. So now we can delete this info log.

@loloicci loloicci closed this as completed Dec 7, 2023
@loloicci
Copy link

loloicci commented Dec 7, 2023

Do you know the background behind why it became necessary to log this information at info level?

I didn't know that, but I heard and researched that this is no more needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants