Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classId of the MsgIssue response of x/token has \" each end of string #463

Closed
4 tasks done
zemyblue opened this issue Mar 16, 2022 · 2 comments
Closed
4 tasks done
Assignees
Labels
A: bug Something isn't working

Comments

@zemyblue
Copy link
Member

zemyblue commented Mar 16, 2022

Summary of Bug

classId of the MsgIssue response of x/token has \" each end of string

For example, if the real response of classId is ca8bfd79, the response is \"ca8bfd79\".

"events": [
          {
            "type": "lbm.token.v1.EventIssue",
            "attributes": [
              {
                "key": "class_id",
                "value": "\"ca8bfd79\""
              }
            ]
          },

Version

lbm-sdk v0.45.0-rc0

Steps to Reproduce

  1. request MsgIssue of x/token
  2. parsing the response.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue zemyblue added the A: bug Something isn't working label Mar 16, 2022
@0Tech
Copy link
Collaborator

0Tech commented Mar 18, 2022

I confirmed the upstream (cosmos-sdk) behaves exactly in the same way as the description here. It is not limited to x/token, but the all events using protobuf.
So I think it's not a bug, or at least not a bug only in our sdk.
We can discuss about it, and decide whether we should fix it and push the fix to the upstream.

@0Tech
Copy link
Collaborator

0Tech commented Apr 11, 2022

We concluded this is not a bug, after the discussion with @zemyblue.
You may re-open the issue if you think this should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants