Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code hygiene: address the inconsistency in the validations on the number of arguments #743

Closed
0Tech opened this issue Oct 19, 2022 · 0 comments · Fixed by #1168
Closed

Code hygiene: address the inconsistency in the validations on the number of arguments #743

0Tech opened this issue Oct 19, 2022 · 0 comments · Fixed by #1168
Assignees
@tkxkd0159
Labels
good first issue Good for newcomers

Comments

@0Tech
Copy link
Collaborator

0Tech commented Oct 19, 2022 

    Both of my comments are about inconsistency of code.

Should these things be fixed in this PR? Or is it better to leave it as an issue in upstream?

Originally posted by @loin3 in #734 (comment)
@0Tech 0Tech added the good first issue Good for newcomers label Oct 19, 2022
@tkxkd0159 tkxkd0159 self-assigned this Oct 31, 2023
@tkxkd0159 tkxkd0159 mentioned this issue Oct 31, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkxkd0159 tkxkd0159

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace ExactArgs(0) with NoArgs Finschia/finschia-sdk
2 participants
@0Tech @tkxkd0159